Skip to content

Use https://github.com/apple/swift-http-types ? #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsonfry opened this issue Mar 6, 2024 · 3 comments
Closed

Use https://github.com/apple/swift-http-types ? #46

jsonfry opened this issue Mar 6, 2024 · 3 comments

Comments

@jsonfry
Copy link
Contributor

jsonfry commented Mar 6, 2024

This is more of a question or thought than a bug...

There's some HTTP implementation here:

https://github.com/swift-server/swift-aws-lambda-events/blob/main/Sources/AWSLambdaEvents/Utils/HTTP.swift

that has a lot of overlap with the recent https://github.com/apple/swift-http-types library.

Would it be a good idea to use the swift-http-types library instead?

@jsonfry jsonfry changed the title Use https://github.com/apple/swift-http-types Use https://github.com/apple/swift-http-types ? Mar 6, 2024
@tomerd
Copy link
Contributor

tomerd commented Mar 6, 2024

could be interesting for sure. do you want to submit a PR?

@jsonfry
Copy link
Contributor Author

jsonfry commented Mar 11, 2024

I may well have a go at it in the next couple of weeks

@sebsto
Copy link
Contributor

sebsto commented May 23, 2024

resolved by #47

@sebsto sebsto closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants