From ce5efaf8e4606a557a71ab2cf5cd99ed59863ec8 Mon Sep 17 00:00:00 2001
From: Lars Toenning <dev@ltoenning.de>
Date: Sun, 24 Mar 2024 15:52:19 +0100
Subject: [PATCH] refactor: Remove separate button to validate flightplan

The flightplan is already automatically validated when sending it to the
server. To simplify the UI, this removes the possibility for this extra check.
---
 src/blackgui/components/flightplancomponent.cpp |  8 --------
 src/blackgui/components/flightplancomponent.h   |  3 ---
 src/blackgui/components/flightplancomponent.ui  | 12 ------------
 3 files changed, 23 deletions(-)

diff --git a/src/blackgui/components/flightplancomponent.cpp b/src/blackgui/components/flightplancomponent.cpp
index 17b0d33b7f..9098017184 100644
--- a/src/blackgui/components/flightplancomponent.cpp
+++ b/src/blackgui/components/flightplancomponent.cpp
@@ -124,7 +124,6 @@ namespace BlackGui::Components
         connect(ui->pb_Send, &QPushButton::pressed, this, &CFlightPlanComponent::sendFlightPlan, Qt::QueuedConnection);
         connect(ui->pb_Download, &QPushButton::pressed, this, &CFlightPlanComponent::loadFlightPlanFromNetwork, Qt::QueuedConnection);
         connect(ui->pb_Reset, &QPushButton::pressed, this, &CFlightPlanComponent::resetFlightPlan, Qt::QueuedConnection);
-        connect(ui->pb_ValidateFlightPlan, &QPushButton::pressed, this, &CFlightPlanComponent::validateFlightPlan, Qt::QueuedConnection);
         connect(ui->tb_SyncWithSimulator, &QPushButton::released, this, &CFlightPlanComponent::syncWithSimulator, Qt::QueuedConnection);
         connect(ui->pb_Prefill, &QPushButton::pressed, this, &CFlightPlanComponent::anticipateValues, Qt::QueuedConnection);
         connect(ui->pb_SimBrief, &QPushButton::pressed, this, &CFlightPlanComponent::loadFromSimBrief, Qt::QueuedConnection);
@@ -528,13 +527,6 @@ namespace BlackGui::Components
         }
     }
 
-    void CFlightPlanComponent::validateFlightPlan()
-    {
-        CFlightPlan flightPlan;
-        const CStatusMessageList messages = this->validateAndInitializeFlightPlan(flightPlan);
-        this->showOverlayMessages(messages);
-    }
-
     void CFlightPlanComponent::resetFlightPlan()
     {
         this->prefillWithOwnAircraftData();
diff --git a/src/blackgui/components/flightplancomponent.h b/src/blackgui/components/flightplancomponent.h
index d6decea116..05fa82b1ef 100644
--- a/src/blackgui/components/flightplancomponent.h
+++ b/src/blackgui/components/flightplancomponent.h
@@ -206,9 +206,6 @@ namespace BlackGui::Components
         //! Load Flightplan
         void loadFlightPlanFromNetwork();
 
-        //! Validate Flightplan
-        void validateFlightPlan();
-
         //! Remarks
         void buildRemarksString();
 
diff --git a/src/blackgui/components/flightplancomponent.ui b/src/blackgui/components/flightplancomponent.ui
index fe0e3f302b..3546ac9c38 100644
--- a/src/blackgui/components/flightplancomponent.ui
+++ b/src/blackgui/components/flightplancomponent.ui
@@ -708,17 +708,6 @@
              </property>
             </widget>
            </item>
-           <item row="0" column="2">
-            <widget class="QPushButton" name="pb_ValidateFlightPlan">
-             <property name="text">
-              <string>&amp;Validate</string>
-             </property>
-             <property name="icon">
-              <iconset resource="../../blackmisc/blackmisc.qrc">
-               <normaloff>:/diagona/icons/diagona/icons/abacus.png</normaloff>:/diagona/icons/diagona/icons/abacus.png</iconset>
-             </property>
-            </widget>
-           </item>
            <item row="2" column="1">
             <widget class="QPushButton" name="pb_LoadDisk">
              <property name="toolTip">
@@ -1168,7 +1157,6 @@
   <tabstop>le_LastSent</tabstop>
   <tabstop>pb_Prefill</tabstop>
   <tabstop>pb_Reset</tabstop>
-  <tabstop>pb_ValidateFlightPlan</tabstop>
   <tabstop>pb_Send</tabstop>
   <tabstop>pb_Download</tabstop>
   <tabstop>pb_SimBrief</tabstop>