fix: Supress false positives

Author: ltoenning

src/misc/aviation/altitude.cpp

@@ -216,7 +216,7 @@ namespace swift::misc::aviation
         // in same step get numeric value only
         bool beforeDigit = true;
         QString numericPart;
-        for (int i = 0; i < v.length(); i++)
+        for (int i = 0; i < v.length(); i++) // NOLINT
         {
             const QChar c = v[i];
             if (c.isDigit())

src/misc/aviation/selcal.cpp

@@ -39,7 +39,7 @@ namespace swift::misc::aviation
         QList<CFrequency> f;
         if (!CSelcal::isValidCode(m_code)) return f;
         f.reserve(m_code.length());
-        for (int pos = 0; pos < m_code.length(); pos++) { f.append(CSelcal::audioFrequencyEquivalent(m_code.at(pos))); }
+        for (const QChar c : m_code) { f.append(CSelcal::audioFrequencyEquivalent(c)); }
         return f;
     }
 

src/misc/simulation/fscommon/bcdconversions.h

@@ -40,7 +40,7 @@ namespace swift::misc
 
         private:
             //! Constructor, only static methods
-            CBcdConversions() {}
+            CBcdConversions() {} // NOLINT(modernize-use-equals-default)
 
             //! Horner scheme
             static quint32 hornerScheme(quint32 num, quint32 divider, quint32 factor);

src/misc/simulation/interpolation/interpolationsetupprovider.h

@@ -118,7 +118,7 @@ namespace swift::misc::simulation
 
     protected:
         //! Default constructor
-        CInterpolationSetupAware() {}
+        CInterpolationSetupAware() {} // NOLINT(modernize-use-equals-default)
 
         //! Constructor
         CInterpolationSetupAware(IInterpolationSetupProvider *setupProvider) : IProviderAware(setupProvider) {}

src/misc/variant.cpp

@@ -498,8 +498,7 @@ namespace swift::misc
     bool CVariant::isA(int metaTypeId) const
     {
         if (metaTypeId == QMetaType::UnknownType) { return false; }
-        if (metaTypeId == getMetaTypeId()) { return true; }
-        return false;
+        return metaTypeId == getMetaTypeId();
     }
 
     bool CVariant::matches(const CVariant &value) const