refactor: Fix readability-static-accessed-through-instance warnings

Author: ltoenning

.clang-tidy

@@ -49,6 +49,7 @@ Checks: >
   readability-use-anyofallof,
   readability-redundant-member-init,
   cppcoreguidelines-init-variables,
+  readability-static-accessed-through-instance,
 
 CheckOptions:
   - key: readability-identifier-naming.ClassCase

src/core/application.cpp

@@ -838,7 +838,7 @@ namespace swift::core
         {
             const CStatusMessage m = this->supportsContexts() ? this->getIContextApplication()->saveSettings() :
                                                                 CSettingsCache::instance()->saveToStore();
-            CLogMessage(this).preformatted(m);
+            CLogMessage::preformatted(m);
         }
 
         // from here on we really rip apart the application object
@@ -870,7 +870,7 @@ namespace swift::core
 
         // clean up all in "deferred delete state"
         qApp->sendPostedEvents(nullptr, QEvent::DeferredDelete);
-        sApp->processEventsFor(500);
+        processEventsFor(500);
 
         // completed
         m_shutdown = true;

src/core/context/contextownaircraftimpl.cpp

@@ -142,7 +142,7 @@ namespace swift::core::context
         ownAircraft.setPilot(m_currentNetworkServer.get().getUser());
 
         // If we already have a model from somehwere, keep it, otherwise init default
-        ownAircraft.setModel(this->reverseLookupModel(ownAircraft.getModel()));
+        ownAircraft.setModel(reverseLookupModel(ownAircraft.getModel()));
         if (!ownAircraft.getAircraftIcaoCode().hasValidDesignator())
         {
             ownAircraft.setModel(getDefaultOwnAircraftModel());
@@ -205,7 +205,7 @@ namespace swift::core::context
 
     bool CContextOwnAircraft::updateOwnModel(const CAircraftModel &model, const CIdentifier &identifier)
     {
-        CAircraftModel updateModel(this->reverseLookupModel(model));
+        CAircraftModel updateModel(reverseLookupModel(model));
         {
             QWriteLocker l(&m_lockAircraft);
             const bool changed = (m_ownAircraft.getModel() != updateModel);

src/core/db/databaseutils.cpp

@@ -179,7 +179,7 @@ namespace swift::core::db
             if (processEvents && c % 125 == 0)
             {
                 if (!sApp || sApp->isShuttingDown()) { return models; }
-                sApp->processEventsFor(25);
+                CApplication::processEventsFor(25);
             }
 
             const QString ms(model.getModelString());
@@ -222,7 +222,7 @@ namespace swift::core::db
             if (processEvents && c % 125 == 0)
             {
                 if (!sApp || sApp->isShuttingDown()) { return models; }
-                sApp->processEventsFor(25);
+                CApplication::processEventsFor(25);
             }
 
             const QString ms(model.getModelString());
@@ -268,7 +268,7 @@ namespace swift::core::db
             if (modified || model.hasValidDbKey())
             {
                 c++;
-                if (processEvents && c % 125 == 0) { sApp->processEventsFor(25); }
+                if (processEvents && c % 125 == 0) { CApplication::processEventsFor(25); }
             }
         }
         CLogMessage(static_cast<CDatabaseUtils *>(nullptr)).info(u"Consolidated %1 models in %2ms")
@@ -374,7 +374,7 @@ namespace swift::core::db
                     const int percentage = c * 100 / maxModelsCount;
                     progressIndicator->updateProgressIndicatorAndProcessEvents(percentage);
                 }
-                else { sApp->processEventsFor(10); }
+                else { CApplication::processEventsFor(10); }
             }
 
             // values to be skipped

src/gui/components/audionotificationcomponent.cpp

@@ -199,7 +199,7 @@ namespace swift::gui::components
                                ui->cb_SetupAudioNotificationLogoff->isChecked());
 
         const CStatusMessage msg = m_audioSettings.set(as);
-        CLogMessage(this).preformatted(msg);
+        CLogMessage::preformatted(msg);
 
         const auto *sender = qobject_cast<const QCheckBox *>(QObject::sender());
         if (checked && sGui && sGui->getCContextAudioBase() && sender)

src/gui/components/copymodelsfromotherswiftversionscomponent.cpp

@@ -175,7 +175,7 @@ namespace swift::gui::components
         if (ui->cb_Silent->isChecked())
         {
             // allow UI updates
-            sApp->processEventsFor(50);
+            CApplication::processEventsFor(50);
             return true;
         }
         const QMessageBox::StandardButton reply = QMessageBox::question(

src/gui/components/dbloadoverviewcomponent.cpp

@@ -31,7 +31,7 @@ namespace swift::gui::components
         //! \fixme KB 201709 It is hard to judge if it is a good idea to trigger cache admit in a UI component
         //  althought admit happens in background, this component might trigger cache reads not needed (though it is not
         //  very likely)
-        this->admitCaches();
+        admitCaches();
 
         ui->lbl_DatabaseUrl->setTextFormat(Qt::RichText);
         ui->lbl_DatabaseUrl->setTextInteractionFlags(Qt::TextBrowserInteraction);

src/gui/components/firstmodelsetcomponent.cpp

@@ -298,7 +298,7 @@ namespace swift::gui::components
 
     QWidget *CFirstModelSetComponent::mainWindow()
     {
-        QWidget *pw = sGui->mainApplicationWidget();
+        QWidget *pw = CGuiApplication::mainApplicationWidget();
         return pw ? pw : this;
     }
 

src/gui/components/infobarstatuscomponent.cpp

@@ -250,8 +250,8 @@ namespace swift::gui::components
 
     void CInfoBarStatusComponent::updateSpacing()
     {
-        if (!sGui || sGui->isShuttingDown() || !sGui->mainApplicationWidget()) { return; }
-        const int w = sGui->mainApplicationWidget()->width();
+        if (!sGui || sGui->isShuttingDown() || !CGuiApplication::mainApplicationWidget()) { return; }
+        const int w = CGuiApplication::mainApplicationWidget()->width();
         const int s = (w >= 400) ? 6 : 2;
         this->setSpacing(s);
     }

src/gui/components/settingshotkeycomponent.cpp

@@ -56,7 +56,7 @@ namespace swift::gui::components
     void CSettingsHotkeyComponent::saveSettings()
     {
         const CStatusMessage msg = m_actionHotkeys.save();
-        CLogMessage(this).preformatted(msg);
+        CLogMessage::preformatted(msg);
     }
 
     void CSettingsHotkeyComponent::registerDummyPttEntry()