Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(es/minifier): Move Pure optimizer to another crate #9946

Closed
wants to merge 1 commit into from
Closed

refactor(es/minifier): Move Pure optimizer to another crate #9946

wants to merge 1 commit into from
+1 −0

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 26, 2025

Description:

This is a groundwork to merge expression simplifier and dead branch remover into the pure optimizer

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 26, 2025
@kdy1 kdy1 self-assigned this Jan 26, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 265cb7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title refactor(es/minifier): Move Pure optimizer into swc_ecma_transforms_optimization refactor(es/minifier): Move Pure optimizer into another crate Jan 26, 2025
@kdy1 kdy1 changed the title refactor(es/minifier): Move Pure optimizer into another crate refactor(es/minifier): Move Pure optimizer to another crate Jan 26, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #9946 will degrade performances by 27.05%

Comparing kdy1:move-pure (265cb7d) with main (37e0ea5)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ es/full/minify/libraries/lodash 240.9 ms 233.1 ms +3.35%
❌ es/full/base/fixer 117.3 µs 160.8 µs -27.05%
❌ es/minifier/libs/moment 97.3 ms 102 ms -4.58%

@kdy1
Copy link
Member Author

kdy1 commented Feb 3, 2025

I'll retry in the future

@kdy1 kdy1 closed this Feb 3, 2025
@kdy1 kdy1 deleted the move-pure branch February 3, 2025 22:04
@kdy1 kdy1 modified the milestones: Planned, v1.10.15 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.10.15
Development

Successfully merging this pull request may close these issues.

Move Pure optimizer into swc_ecma_transforms_optimization
1 participant
@kdy1