Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all structure placement tests get exercised #2148

Open
kostmo opened this issue Sep 16, 2024 · 0 comments
Open

Ensure all structure placement tests get exercised #2148

kostmo opened this issue Sep 16, 2024 · 0 comments
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Structures Structures (i.e. recognizable groupings of entities in the world) T-Testing Involves the testing suite - unit and integration tests, also benchmarks. Z-Feature A new feature to be added to the game.

Comments

@kostmo
Copy link
Member

kostmo commented Sep 16, 2024

Some tests for structure placement added in #1826 were "visual-only" and not executed as part of the test suite.

Either we should:

  • Define (possibly trivial) goal conditions and add them to the executable test list
  • Convert them to image-based test fixtures
  • Remove them.
@kostmo kostmo added Z-Feature A new feature to be added to the game. T-Testing Involves the testing suite - unit and integration tests, also benchmarks. labels Sep 16, 2024
@byorgey byorgey added C-Low Hanging Fruit Ideal issue for new contributors. G-Structures Structures (i.e. recognizable groupings of entities in the world) labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Structures Structures (i.e. recognizable groupings of entities in the world) T-Testing Involves the testing suite - unit and integration tests, also benchmarks. Z-Feature A new feature to be added to the game.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kostmo @byorgey