non-empty stderr for go list is not an error in itself (#1981)

atercattus · web-flow · commit 257c97c9d61c · 2025-03-21T09:54:46.000+08:00
diff --git a/golist.go b/golist.go
@@ -22,7 +22,7 @@ func listPackages(ctx context.Context, dir string, env []string, args ...string)
 	var stderrBuf bytes.Buffer
 	cmd.Stderr = &stderrBuf
 	defer func() {
-		if stderrBuf.Len() > 0 {
+		if (finalErr != nil) && (stderrBuf.Len() > 0) {
 			finalErr = fmt.Errorf("%v\n%s", finalErr, stderrBuf.Bytes())
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ func listPackages(ctx context.Context, dir string, env []string, args ...string)`
`22`	`22`	`var stderrBuf bytes.Buffer`
`23`	`23`	`cmd.Stderr = &stderrBuf`
`24`	`24`	`defer func() {`
`25`		`- if stderrBuf.Len() > 0 {`
	`25`	`+ if (finalErr != nil) && (stderrBuf.Len() > 0) {`
`26`	`26`	`finalErr = fmt.Errorf("%v\n%s", finalErr, stderrBuf.Bytes())`
`27`	`27`	`}`
`28`	`28`	`}()`