Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement promises #4

Open
antoine-pous opened this issue Jan 10, 2018 · 2 comments
Open

Implement promises #4

antoine-pous opened this issue Jan 10, 2018 · 2 comments

Comments

@antoine-pous
Copy link
Contributor

Hi,

can you implement promise when the callback is not provided? Promises are really usefull :)
@svenpaulsen
Copy link
Owner

To be honest... I'm not familiar with the concept of promises. Can you provide a short example?

@antoine-pous
Copy link
Contributor Author

You can see an implementation on my ServerQuery client here https://github.com/antoine-pous/node-teamspeak3-client

I'm not familiar with this approach to interface the SDK and nodejs, i don't know how to update the sources to improve the compiled code in ts3client.node and implement Promises and eventemitter2.

If you want you can take a look to my fork https://github.com/antoine-pous/node-ts3sdk-client/tree/typescript-tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoine-pous @svenpaulsen