-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: remove postinstall
script in favor of prepublish
script
#615
Comments
the message is intended for users, but I agree that it would be better if it was made at runtime if a missing dependency was detected. vite handles this for sass for example, reminding you to install it if you didn't |
it is however not a security issue in this case as it only runs "echo". You can safely disable this postinstall script with your package manager if it still concerns you |
postinstall cause install failed
solved after move into optionalDependencies |
See also: @SocketDev
Feature requests and proposals
The
postinstall
script will always run, even for deeply nested dependencies.The
prepublish
script will run when someone is runningnpm install
from the repo, and beforenpm publish
.Currently the install script is used to write a message to the screen which is not actually necessary for people who have this as a dependency.
The text was updated successfully, but these errors were encountered: