Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration changes unnecessary lines #364

Open
mig-hub opened this issue Dec 18, 2024 · 0 comments
Open

Migration changes unnecessary lines #364

mig-hub opened this issue Dec 18, 2024 · 0 comments

Comments

@mig-hub
Copy link

mig-hub commented Dec 18, 2024

I know it is minor, but the migration script to svelte-5 changes unnecessary lines.

e.g.

{#if title?.length }

Becomes:

{#if title?.length}

Note the space removed before the closing curly bracket.

I know this space might not be the current coding style but I personally like it that way. And the point is that the script should not change a line if it is functionally correct. Otherwise it makes the git commit bigger for nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant