Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError with serverless 2.x #34

Open
jormaechea opened this issue Mar 5, 2021 · 3 comments
Open

TypeError with serverless 2.x #34

jormaechea opened this issue Mar 5, 2021 · 3 comments

Comments

@jormaechea
Copy link

jormaechea commented Mar 5, 2021

The following line is breaking in v2.x because this._serverless.variables.options is undefined.

if (this._serverless.variables.options.stage) {

Are you accepting PRs for this plugin? If so, I can add it quickly. It's stopping us from migrating to serverless 2.x.
Thanks!

Update: tracked it down to v2.26.0. It works properly until v2.25.2

@medikoo
Copy link
Collaborator

medikoo commented Aug 26, 2021

It was fixed on Framework side, still such usage will break with upcoming v3 release of a Framework

@svdgraaf
Copy link
Owner

A PR was just merged which fixes this issue

@jormaechea
Copy link
Author

@svdgraaf the new release broke the plugin. I think you released from develop, not from master.

An issue for this has been created already: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants