Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the latest DAGMC with latest OpenMC #795

Open
shimwell opened this issue Feb 17, 2022 · 4 comments
Open

Testing the latest DAGMC with latest OpenMC #795

shimwell opened this issue Feb 17, 2022 · 4 comments

Comments

@shimwell
Copy link
Member

Is your feature request related to an enhancement? Please describe.

We could add some CI to DAGMC that checks that the compiling of DAGMC with OpenMC continues to work

Is your feature request related to a problem? Please describe.

It is currently possible that we merge code into DAGMC that for some reason does not compile with OpenMC.
I believe this is performed manually currently.

Describe the solution or outcome you'd like.

A clear and concise description of what you want to happen.
A new GitHub action that downloads the development branch of OpenMC and compiles OpenMC with DAGMC enabled.

Describe alternatives you've considered.

A clear and concise description of any alternative solutions or features you've considered.
Ideally some DAGMC specific OpenMC tests would be run to check that the combination of the codes work as expected. However I think that can be a follow up feature PR.
This has not been possible to carry out in the public CI with other export controlled codes, so I don't think we can consider doing this with other neutronics codes.

@pshriwise
Copy link
Member

What would you think of doing this only on pushes to develop?

@makeclean
Copy link
Contributor

makeclean commented Feb 19, 2022 via email

@pshriwise
Copy link
Member

Yeah, you're right @makeclean. I'm having deja vu as I'm pretty sure we've had this whole conversation before and somehow I've totally forgotten 😆

@shimwell we test against DAGMC's develop branch in OpenMC's CI. This is only checked when OpenMC PR's are merged of course, not when new changes come into DAGMC.

If we'd like to test more frequently, maybe a separate repo specifically for this purpose with a GHA triggered by either a merged OpenMC or DAGMC PR would be the way to go.

@shimwell
Copy link
Member Author

If we'd like to test more frequently, maybe a separate repo specifically for this purpose with a GHA triggered by either a merged OpenMC or DAGMC PR would be the way to go.

That sounds interesting, I am just not sure how to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants