-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing the latest DAGMC with latest OpenMC #795
Comments
What would you think of doing this only on pushes to |
I wonder if this shouldn't be the other way around? We build and test the dagmc codes, as these are 'our' dagmc versions of those codes, fludag and daggeant4 etc i.e. we depend upon those codes. Where as dagmc is a dependency of openmc, I think openmc should check to see if it builds against dagmc.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Patrick Shriwise ***@***.***>
Sent: Saturday, February 19, 2022 3:26:52 PM
To: svalinn/DAGMC ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [svalinn/DAGMC] Testing the latest DAGMC with latest OpenMC (Issue #795)
What would you think of doing this only on pushes to develop?
—
Reply to this email directly, view it on GitHub<#795 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AASTUSWYAGWWPEIY4KWRYWTU36ZDZANCNFSM5OVB2QDQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Yeah, you're right @makeclean. I'm having deja vu as I'm pretty sure we've had this whole conversation before and somehow I've totally forgotten 😆 @shimwell we test against DAGMC's develop branch in OpenMC's CI. This is only checked when OpenMC PR's are merged of course, not when new changes come into DAGMC. If we'd like to test more frequently, maybe a separate repo specifically for this purpose with a GHA triggered by either a merged OpenMC or DAGMC PR would be the way to go. |
That sounds interesting, I am just not sure how to do it |
Is your feature request related to an enhancement? Please describe.
We could add some CI to DAGMC that checks that the compiling of DAGMC with OpenMC continues to work
Is your feature request related to a problem? Please describe.
It is currently possible that we merge code into DAGMC that for some reason does not compile with OpenMC.
I believe this is performed manually currently.
Describe the solution or outcome you'd like.
A clear and concise description of what you want to happen.
A new GitHub action that downloads the development branch of OpenMC and compiles OpenMC with DAGMC enabled.
Describe alternatives you've considered.
A clear and concise description of any alternative solutions or features you've considered.
Ideally some DAGMC specific OpenMC tests would be run to check that the combination of the codes work as expected. However I think that can be a follow up feature PR.
This has not been possible to carry out in the public CI with other export controlled codes, so I don't think we can consider doing this with other neutronics codes.
The text was updated successfully, but these errors were encountered: