Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require minimum version of MOAB #788

Open
gonuke opened this issue Nov 13, 2021 · 6 comments
Open

Require minimum version of MOAB #788

gonuke opened this issue Nov 13, 2021 · 6 comments

Comments

@gonuke
Copy link
Member

gonuke commented Nov 13, 2021

We should assert a minimum version of MOAB that is necessary for compatibility. However, MOAB does not currently report its version number in the CMake infrastructure, so we don't have a good way to check.

A PR has been launched into MOAB to add this (https://bitbucket.org/fathomteam/moab/pull-requests/571) so this issue can be addressed when that is released, hopefully v5.3.2 or 5.4

This will hopefully just require an update to the find_package call in our CMake to specify the minimum version

@pshriwise
Copy link
Member

@gonuke was this resolved in MOAB? I see your PR went in and was potentially replaced by another, but I couldn't track a replacement PR down.

@gonuke
Copy link
Member Author

gonuke commented Feb 19, 2022

I don't think so. There has not been a release since this issue was posted.

@gonuke
Copy link
Member Author

gonuke commented Feb 19, 2022

I think there are just bigger issues in MOAB's build infrastructure. I seem to recall that this PR may have motivated a discussion about moving to CMake as the primary build system for MOAB, though?

@ahnaf-tahmid-chowdhury
Copy link
Member

It seems the PR is closed. Should we still consider setting the minimum version of MOAB to 5.4?

@gonuke
Copy link
Member Author

gonuke commented Feb 16, 2024

Does MOAB now report a version number that can be queried by FindMOAB or similar in CMake?

@ahnaf-tahmid-chowdhury
Copy link
Member

Sorry, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants