Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uwuw_preprocessor::check_material_props is not used anywhere #723

Open
helen-brooks opened this issue Jan 21, 2021 · 2 comments
Open

uwuw_preprocessor::check_material_props is not used anywhere #723

helen-brooks opened this issue Jan 21, 2021 · 2 comments

Comments

@helen-brooks
Copy link
Collaborator

The private method uwuw_preprocessor::check_material_props is not used anywhere. It's not clear to me which of the following apply:

  1. this is dead code, or
  2. it should be used somewhere, or
  3. it should be public so that it is available for use.

Depending on which of the above apply, I propose one of the following fixes:
If it is dead code, then method should be deleted.
If it should be performing a check somewhere (even optionally) then add this feature.
If it is simply intended as a useful debugging tool, suggest that it made public and used in a test case with examples that both pass and fail test.

@ahnaf-tahmid-chowdhury
Copy link
Member

The function uwuw_preprocessor::check_material_props validates material assignments for a given volume, reporting errors for missing or multiple material properties.

It seems, it is not added in unit tests.

@gonuke
Copy link
Member

gonuke commented Feb 16, 2024

I think the best thing to do would be to make this method public and add a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants