Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP-mode changed the way to check for yasnippet #6

Closed
FrauH0lle opened this issue Jun 13, 2024 · 2 comments
Closed

LSP-mode changed the way to check for yasnippet #6

FrauH0lle opened this issue Jun 13, 2024 · 2 comments

Comments

@FrauH0lle
Copy link

Since emacs-lsp/lsp-mode#4413, lsp-mode does not check via featurep anymore but (fboundp 'yas-minor-mode).
Thus, lsp-snippet-tempel-lsp-mode-init would need to provide the minor mode instead.

I have asked at lsp-mode here if they would consider to allow other snippet expansion libraries, which would make the integration simpler.

@svaante svaante closed this as completed in 566c0db Oct 2, 2024
@svaante
Copy link
Owner

svaante commented Oct 2, 2024

Sorry for taking such a long time to respond.

I suspect that you have stopped using lsp-snippet but your issue should be fixed by commit above

@FrauH0lle
Copy link
Author

Thanks a lot for the fix.
I still use lsp-snippet and everything is working like a charm. Great package!
By using el-patch I implemented fixes for this issue here and also for #5 plus a hack which uses completing-read for choices in snippets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants