Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Is the absence of a fix flag in the inputs of "github-action-tflint" when called from the "test-module" intentional by design? #2175

Closed
falcon-tech opened this issue Dec 30, 2024 · 4 comments · Fixed by #2176
Closed

Question: Is the absence of a fix flag in the inputs of "github-action-tflint" when called from the "test-module" intentional by design? #2175

falcon-tech opened this issue Dec 30, 2024 · 4 comments · Fixed by #2176
Labels
enhancement New feature or request question Further information is requested
Milestone
v1.14.0

Comments

@falcon-tech
Copy link

Question

The "github-action-tflint" called in "test-module" does not have a fix flag in its inputs, whereas the one called in "test" does include a fix flag.

Call github-action-tflint in test-module

image

Call github-action-tflint in test

image

Background

No response

Note

No response
@falcon-tech falcon-tech added the question Further information is requested label Dec 30, 2024
@suzuki-shunsuke
Copy link
Owner

Thank you for your feedback.
I don't think it's design.
I'll take a look.

@suzuki-shunsuke suzuki-shunsuke mentioned this issue Dec 30, 2024
Merged
@suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Dec 30, 2024
@suzuki-shunsuke suzuki-shunsuke added this to the v1.14.0 milestone Dec 30, 2024
@falcon-tech
Copy link
Author

Thank you for the quick fix!

@suzuki-shunsuke
Copy link
Owner

🎉 https://github.com/suzuki-shunsuke/tfaction/releases/tag/v1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

feat(test-module): support tflint --fix suzuki-shunsuke/tfaction
2 participants
@suzuki-shunsuke @falcon-tech