You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The _transferFeesAndFunds method of BaseExchange.sol tries to retrieve the royalty info from the NFT contract. This requires the contract to implement the ERC2981.
As I understand, for contracts not created via Shoyu and thus probably not having an exchange implemented, ERC721ExchangeV0.sol should act as a more generic version of the exchange allowing to trade allowed NFTs.
Shouldn't we allow existing NFT projects to set a royalty fee if ERC2981 isn't implemented in their existing contract? I'm concerned the marketplace wouldn't be a good fit for a lot of the existing projects otherwise.
The text was updated successfully, but these errors were encountered:
The
_transferFeesAndFunds
method ofBaseExchange.sol
tries to retrieve the royalty info from the NFT contract. This requires the contract to implement the ERC2981.shoyu/contracts/base/BaseExchange.sol
Lines 296 to 304 in 3d84540
As I understand, for contracts not created via Shoyu and thus probably not having an exchange implemented,
ERC721ExchangeV0.sol
should act as a more generic version of the exchange allowing to trade allowed NFTs.Shouldn't we allow existing NFT projects to set a royalty fee if ERC2981 isn't implemented in their existing contract? I'm concerned the marketplace wouldn't be a good fit for a lot of the existing projects otherwise.
The text was updated successfully, but these errors were encountered: