Skip to content

Commit a7f82da

Browse files
authored
Mobile matrix footer - addRowLocation - top #9425 (#9427)
* Mobile matrix footer - addRowLocation - top #9425 Fixed #9425 * #9410 update screenshots
1 parent 2e28f33 commit a7f82da

File tree

6 files changed

+44
-1
lines changed

6 files changed

+44
-1
lines changed

packages/survey-core/src/default-theme/blocks/sd-matrixdynamic.scss

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,25 @@
77
z-index: 12;
88
}
99

10+
.sd-question--mobile .sd-matrixdynamic__footer::before
11+
{
12+
z-index: 12;
13+
content: " ";
14+
display: block;
15+
position: relative;
16+
height: 1px;
17+
background-color: $border-light;
18+
left: calcSize(-3);
19+
top: calcSize(-1);
20+
width: calc(100% + 6 * #{$base-unit});
21+
z-index: 12;
22+
}
23+
1024
.sd-matrixdynamic__footer:first-child {
1125
padding-bottom: calcSize(2);
26+
&::before {
27+
display: none;
28+
}
1229
}
1330

1431
.sd-matrixdynamic__footer {

packages/survey-core/src/default-theme/blocks/sd-table.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,9 @@
615615
tr:not(.sd-table__row--expanded)::after {
616616
bottom: 0;
617617
}
618+
tr:last-of-type::after {
619+
display: none
620+
}
618621

619622
tfoot tr {
620623
padding-top: calcSize(5);
39 KB
Loading
-10 Bytes
Loading
-227 Bytes
Loading

visualRegressionTests/tests/defaultV2/responsiveness.ts

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,35 @@ frameworks.forEach(framework => {
267267
addRowText: "Add a New Record",
268268
rowCount: 2,
269269
},
270+
{
271+
type: "matrixdynamic",
272+
name: "frameworks1",
273+
title: "Please tells us your opinion about JavaScript MVVM frameworks.",
274+
columns: [
275+
{
276+
"name": "Column 1",
277+
"title": "Framework"
278+
},
279+
{
280+
"name": "Column 2",
281+
"title": "How long do you use it?"
282+
},
283+
{
284+
"name": "Column 3",
285+
"title": "What is main strength?"
286+
}
287+
],
288+
addRowText: "Add a New Record",
289+
rowCount: 2,
290+
"addRowLocation": "top"
291+
},
270292
]
271293
});
272294
await ClientFunction(() => {
273295
document.body.focus();
274296
})();
275-
await takeElementScreenshot("responsiveness-matrixdynamic.png", Selector(".sd-question"), t, comparer);
297+
await takeElementScreenshot("responsiveness-matrixdynamic.png", Selector(".sd-question").nth(0), t, comparer);
298+
await takeElementScreenshot("responsiveness-matrixdynamic-add-top.png", Selector(".sd-question").nth(1), t, comparer);
276299
});
277300
});
278301
test("Check matrixdynamic on small screen with errors", async (t) => {

0 commit comments

Comments
 (0)