Version 2 (published as next to NPM) #57
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
=========================================
Coverage ? 76.82%
=========================================
Files ? 12
Lines ? 1139
Branches ? 274
=========================================
Hits ? 875
Misses ? 203
Partials ? 61 ☔ View full report in Codecov by Sentry. |
| return result | ||
| } catch (err) { | ||
| if (err instanceof QueueDoesNotExist) { | ||
| console.error(chalk.yellow('This error can occur when you run this command immediately after deleting a queue. Wait 60 seconds and try again.')) |
There was a problem hiding this comment.
@ryanwitt do we have a way to retry this if this is being called from the application job?
There was a problem hiding this comment.
No, but I think we should build it into qdone soon.
|
|
||
| export const defaults = Object.freeze({ | ||
| // Shared | ||
| prefix: 'qdone_', |
There was a problem hiding this comment.
@ryanwitt what is the implication of these defaults? did defaults exist before?
There was a problem hiding this comment.
Yes, they were, but only on the command line. This made using the internal API awkward, and these defaults make it easy and consistent between the two. You'll see that the internal PR uses the camelCase style naming now.
Return deduplicationId to callers of enqueue() and enqueueBatch()
Delete idle queues updates
Load calculation fixes / qrlCache fixes
Various fixes from monitoring of 2.0.51-alpha
ryanwitt
changed the title
Closes #24
Closes #36
Closes #53
Closes #55
Closes #58
Changelog
v.2.0.3-alpha
New Features
Added DLQ option for enqueue (#24)
By default, we always create a single fail queue, but now we create a dlq for some queues.
Added
--sentry-dsnoptiontodo
Added
--delayoption (#36)todo
Added
--tagoption (#53)This option supports AWS cost tags. These are only supported on queue creation. You may have to manually tag queues that already exist, or cull the queues using the
idleQueuescommand and then tag them on next creation.Tags for the CLI
The
enqueuecommand now supports the option--tag <tag>where<tag>is formatted likeKey=Valuelike the AWS cli. The--tagoption may be specified multiple times, up to the AWS limit.Tags for Node
The
enqueueandenqueueBatchexports now support atagsoption where tags are formatted as keys/values of an object, for example:{ ... tags: { Role: 'app', Environment: 'production' } ... }.Monitoring tool for multiple queues
todo
Official Node API
Though qdone was originally supposed to be used from the command line, many users are using the
enqueueandenqueueBatchmethods exported by v1. Now we are adding official support for these.Incompatible changes
Under the hood
Qstrip-ansijesttest.cli.js