Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --retry-count option #54

Closed
ryanwitt opened this issue Dec 1, 2023 · 2 comments
Closed

Add --retry-count option #54

ryanwitt opened this issue Dec 1, 2023 · 2 comments
Assignees

Comments

@ryanwitt
Copy link
Member

ryanwitt commented Dec 1, 2023

This would control the number of failures allowed before the queue sends jobs to failed.

usage: --retry-count <number>

@ryanwitt ryanwitt self-assigned this Dec 1, 2023
@ShaneOH
Copy link

ShaneOH commented Dec 8, 2023

@ryanwitt I would consider this as potentially redundant:

  • Expected retries can be handled by application code (e.g. see 429 code => application code should re-enqueue onto original queue with --delay option)
  • Any given failure will be sent to a _failed queue which should then have its own retry policy: https://github.com/suredone/suredone/issues/9553

So like you mentioned on the call, I'm not sure we need to spend time adding retries onto "normal" queues since that can be handled via app code + failed queues

@ryanwitt
Copy link
Member Author

As per discussion with @ShaneOH, this makes more sense as a retry count on the failure queue, so this will be closed in favor of #24 which has a --dlq-after option which specifies the number of failures on the _failed queue before request will be driven to DLQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants