Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of /recipe/thirdparty import by removing default logos from it #832

Open
porcellus opened this issue Jun 24, 2024 · 0 comments

Comments

@porcellus
Copy link
Collaborator

We could do something like this:

  • getLogo can already return undefined, so we can remove the default impl from all built-in providers
  • move the logos into the assets directory
  • make getButton take a defaultLogos param that the default impl can use
  • update where we call getButton to use the logos from the assets dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant