Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for graph overview support #48

Open
shay23b opened this issue Aug 17, 2023 · 2 comments
Open

Changes for graph overview support #48

shay23b opened this issue Aug 17, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@shay23b
Copy link

shay23b commented Aug 17, 2023

We need to add a few things:

  • Create applicationId as a global var (uuid) - happens in Go SDK in function init() which is not exported to the user, it happens every time you run the app
  • Add app_id to producer & consumer creation req
  • producer & consumer creation req version - 3

These changes are not exported to the client, only for internal usage

For reference the Go SDK:
superstreamlabs/memphis.go#115

@shay23b shay23b added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 17, 2023
@Durdush
Copy link

Durdush commented Aug 22, 2023

Hi @shay23b, Could you please assign this issue?

@yanivbh1
Copy link
Contributor

Hey @Durdush,
Currently, @rnowling-memphis is leading the Java SDK. @rnowling-memphis is it possible to offload some of the work from your to @Durdush, or with the current status of the Java SDK it would be too hard to collaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants