Let's ship it?

[mk6i]

@crocodele What are your thoughts for next steps? I was thinking the next two milestones would be for Supermetrics to dogfood php-ext-jsonpath and then submit to PECL once we're confident that it's production-grade.

[crocodele]

@mkaminski1988, yes, I will apply for the PECL account to get the process started. 🙂

[crocodele]

It's a while since I applied for the PECL account, but I haven't heard back yet. I'll wait a few more days and then I'll ask in the newsgroup.

On a completely different topic, could you @mkaminski1988 please send me a ping to [email protected] so I get your e-mail address?

[mk6i]

Thanks for the update, maybe everyone's on vacation!

Sent you an email.

[Danack]

It's a while since I applied for the PECL

@crocodele fyi, I don't think the application was processed. You may have failed the captcha which is deliberately obtuse, for quite bad reasons.

I say that the application wasn't processed, as I can't see an account request (which looks like https://news-web.php.net/php.pecl.dev/17353) in the mailing list: https://news-web.php.net/group.php?group=php.pecl.dev

Feel free to put me as the sponsor.

[mk6i]

Thanks for the info @Danack 🌮

[crocodele]

@Danack, the application must have ended up in some weird limbo state. When I try to submit the form now with the same username and e-mail address, I get Sorry, that username is already taken and Sorry, that email is already registered in the database. Can you find and enable this account, or should I try again with another username and e-mail address?

Username: viktor
E-mail address: [email protected]

[mk6i]

Regarding Dan Ackroyd's comment:

Hi Viktor,

For entertainment, I checked out the extension and ran the tests with
valgrind i.e. with "php run-tests.php -m -j4". There seem to be a few
invalid reads for a couple of the tests; output is below.

I haven't looked at each test case that causes the errors he reported. For the ones I did look at, commenting out calls to php_pcre_match_impl() in the interpreter "fixed" the error (even if the test failed).

I think there might be a bug in php_pcre_match_impl() itself. For example, I can reproduce half of the example error provided by Dan with the following PHP script, which does not execute the JSONPath extension code.

<?php

preg_match('/(a)(b)*(c)/', 'xxxxxx', $matches);
var_dump($matches);

USE_ZEND_ALLOC=0 valgrind --leak-check=full php test.php

Which outputs the following for me on php 8.0.8/gcc 7.5.0:

==14692== Conditional jump or move depends on uninitialised value(s)
==14692==    at 0x403AAAD: ???
==14692==    by 0x932DC67: ???
==14692==    by 0x932DC67: ???
==14692==    by 0x932DC6D: ???
==14692==    by 0x91301EF: ???
==14692==    by 0x932DC67: ???

cc @Danack

[Danack]

Bug reported: https://bugs.php.net/bug.php?id=81240

As enabling debug 'makes this go away', there's a reasonable chance that it's a bug in PHP rather than the underlying pcre library.

[crocodele]

Thank you both! ❤️

[Danack]

@mkaminski1988 in case you didn't see the update on what I thought was a bug - it turns out when you enable debug in PHP, that enables compiling with valgrind support, which stops valgrind from issuing false reports.

So as there's no visible problem, and the valgrind report goes away in the debug build, then it's more likely to be a false valgrind report, rather than an actual issue. Probably.

[cmb69]

My apologies regarding not having approved the PECL account request of @crocodele earlier. Apparently, the notification mail had not been sent. If you have any questions regarding the PECL account, feel free to ask on the mailing list, or just ping me on GH. Happy PECLing! :)

[crocodele]

Thank you @cmb69 and @Danack! Managed to log in now, register the package, and publish the first release. 🎉

[mk6i]

Wow, this is huge! Nice work, Viktor! Do I need to register for a PECL account to be listed as a maintainer as well? Sent from ProtonMail for iOS

…

On Sat, Aug 7, 2021 at 6:56 AM, Viktor Djupsjöbacka ***@***.***> wrote: Thank you ***@***.***(https://github.com/cmb69) and ***@***.***(https://github.com/Danack)! Managed to log in now, register the package, and publish the first release. 🎉 — You are receiving this because you were mentioned. Reply to this email directly, [view it on GitHub](#120 (reply in thread)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAWCT6WLJT6TBKBPUPBEGMDT3UGNBANCNFSM47M7AP2A). Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email).

[crocodele]

@mkaminski1988, yup, you need a PECL account too.

[cmb69]

Then goto https://pecl.php.net/account-request.php. :)

[mk6i]

Submitted :)

[cmb69]

Approved. :)