Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure login disabled: improve security of "Show account private key" modal. #3397

Open
onvisions opened this issue Nov 14, 2024 · 0 comments

Comments

@onvisions
Copy link
Collaborator

Related to: #3362 (comment)

Currently if the secure login has been disabled the user is able to see the private key as soon as Show private key modal is opened.

Current state (see recording):

showKey.mp4

Problem: Security risk. When the user is clicking on the "Key" button on Account details screen they might not be aware the account private key will be displayed directly and without warning on the very next step of the flow. So the user might not be in a safe environment (the screen might be exposed to surveillance camera etc.)

Suggested solution: the private key should be displayed blurred until the user clicks on the "Show private key" button. Some browsers don't support properly blurring so we may show the key with dots and then apply the blurring. The aim is to have the key hidden until user clicks on the "Show private key" button.

DESIGN:

Browsers supporting blur:
Image

Browsers not supporting blur:
Image

Image

FIGMA REFERENCE:
https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=37597-265273&node-type=frame&t=hvQBU9kxFrQhm7zE-0

@onvisions onvisions changed the title Password disabled: Show account private key modal improvement. Secure login disabled: improve security of "Show account private key" modal. Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant