Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Details Improvements for tokens #3372

Open
smaroudasunicorn opened this issue Oct 31, 2024 · 5 comments
Open

Transaction Details Improvements for tokens #3372

smaroudasunicorn opened this issue Oct 31, 2024 · 5 comments
Assignees

Comments

@smaroudasunicorn
Copy link
Collaborator

smaroudasunicorn commented Oct 31, 2024

The following improvements are proposed for transaction details:\

  1. Provide a link to token name to navigate to token details page
  2. Display FIAT Value information as defined on the transaction date. (Same to be displayed on transaction List)
@smaroudasunicorn
Copy link
Collaborator Author

smaroudasunicorn commented Nov 6, 2024

@onvisions can you help for this ticket too?

@smaroudasunicorn
Copy link
Collaborator Author

smaroudasunicorn commented Nov 6, 2024

We can achieve it for token details without performance impact and additional complexity. Let 's proceed with that first

@smaroudasunicorn
Copy link
Collaborator Author

smaroudasunicorn commented Nov 6, 2024

@CedrikNikita we would like to explore how to achieve to show historical data for every transaction. Following a sync with @paolomolo

@onvisions
Copy link
Collaborator

onvisions commented Nov 8, 2024

@smaroudasunicorn @CedrikNikita
If we can follow the price history and draw a chart we can include such feature on the token details page. We can also think of user's portfolio showing the buys/sells and the average gains for specific token.

Regarding the scope of the current task I am suggesting the following as MVP:

1. Transaction details page:

Token sale: BUY

  • show "Buy price" (AE and Fiat);
  • show "Current price" (AE and Fiat);
  • show the percentage of price change.

Token sale: SELL

  • show "Sell price" (AE and Fiat);
  • show "Current price" (AE and Fiat);
  • show the percentage of price change.

DESIGN:

  1. Token Sale - Buy (price increased)

Image

  1. Token Sale - Buy (price decreased)

Image

  1. Token Sale - Sell (price increased)

Image

  1. Token Sale - Sell (price decreased)

Image

FIGMA REFERENCE: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=37558-322970&node-type=frame&t=AZN7JJF0uYJ7uRwk-0

2. Transactions list: (we keep it as it is)
Token sale: BUY

  • Tokens bought;
  • AE Spent; (should we include here also the transaction fee and gas costs?)
  • Fiat value of AE Spent (fiat is calculated always at the present moment).

Image

Token sale: SELL

  • Tokens sold;
  • AE Received; (should we deduct here the transaction fee and gas costs?)
  • Fiat value of AE Received (fiat is calculated always at the present moment).

Image

All fiat values should be always calculated based on the price of the asset compared to fiat at the present moment.

@onvisions
Copy link
Collaborator

onvisions commented Nov 12, 2024

DESIGN V2
@smaroudasunicorn
In this suggestion we track the price of the ADASTRA token against AE coin and USD (fiat) at the moment of BUY/SELL and at the current moment; The change of price is also displayed in %:

  1. BUY

Image

  1. SELL

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants