fix: empty array on select yields error#82
Open
filipecabaco wants to merge 1 commit into
Open
Conversation
Fixes the behaviour where empty array would be handled as a NULL meaning the user could be mislead into thinking that they were properly filtering data when they weren't.
The behaviour now is:
* `NULL` returns all columns
* `{}` errors out so we can inform the user
https://linear.app/supabase/issue/REAL-843/treat-empty-pg-changes-select-as-an-error
filipecabaco
force-pushed
the
fix/select-empty-handling-real-843
branch
from
5f357f7 to
1f8285f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes the behaviour where empty array would be handled as a NULL meaning the user could be mislead into thinking that they were properly filtering data when they weren't.
The behaviour now is:
NULLreturns all columns{}errors out so we can inform the userhttps://linear.app/supabase/issue/REAL-843/treat-empty-pg-changes-select-as-an-error