fix(release): pin npm to 11.5.2 so OIDC trusted publisher works#249
Open
mandarini wants to merge 1 commit into
Open
fix(release): pin npm to 11.5.2 so OIDC trusted publisher works#249mandarini wants to merge 1 commit into
mandarini wants to merge 1 commit into
Conversation
actions/setup-node ships Node 22 with npm 10.9.x, which has no OIDC trusted-publisher code path. Without npm >= 11.5.1 the publish step falls back to the .npmrc placeholder _authToken written by setup-node (literal "XXXXX-XXXXX-XXXXX-XXXXX") and the registry returns 404 Not Found on PUT. This regressed in #221 when the corepack-prepare-npm@11 line was removed with the claim "no longer needed". It went undetected for ~4 weeks because every release run between then and now hit the skip=true branch (no pending release-please PR on those chore commits). The regression surfaced once #240, #245, and #244 needed real publishes — all three release runs failed with the same E404. The repo has no NPM_TOKEN by design (PR #221 kept OIDC-only auth to avoid a long-lived token). Re-add a pinned npm bump so the publish step has a CLI that knows how to do the trusted-publisher exchange. Comment in the workflow explains the dependency so the line is not deleted again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
spydon
reviewed
Jun 8, 2026
o-santi
approved these changes
Jun 8, 2026
spydon
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The release pipeline has been silently broken since #221 (May 12). That PR removed
corepack enable npm && corepack prepare npm@11 --activatewith the claim "no longer needed", butactions/setup-node@v6.4.0does not upgrade npm — Node 22 ships with npm 10.9.x.npm only learned how to do OIDC trusted-publisher exchange in 11.5.1. On npm 10,
npm publish --provenancesigns the provenance via sigstore (which works because it uses the GitHub OIDC token directly), then sends the bogus.npmrcplaceholderXXXXX-XXXXX-XXXXX-XXXXXas the bearer token to the registry. The registry returns404 Not Found - PUT https://registry.npmjs.org/@supabase%2fssr(npm registry returns 404 for unauthenticated PUTs to avoid leaking which packages exist).The repo has no
NPM_TOKENsecret configured anywhere — by design, per #221's hardening posture. Auth is OIDC-only via the trusted-publisher binding on npmjs.com. Re-adding a token would weaken that posture, so the fix is to ensure the npm CLI is new enough to use OIDC.Why this went undetected
Between #221's merge (May 12) and #240's merge (June 4), every release run was for a
chore: update @supabase/supabase-jscommit. Those have no pending release-please PR, so the workflow's version-determination step took theskip=truebranch and never attempted to publish. The first publish attempt on npm 10 — #240's merge on June 4 — failed with E404, as did the two release runs after it (#245, #244).Failed runs:
0.12.0-rc.1180.11.0-rc.117Last successful publish:
v0.10.3on May 7 (run 25509681243), which ran on npm 11 via the corepack line that #221 removed.