We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
migrations/tests/database/exists.sql
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We currently have these tests:
postgres/migrations/tests/database/exists.sql
Lines 2 to 8 in 61ff753
As one example, has_schema('storage'); is redundant with
has_schema('storage');
postgres/nix/tests/expected/storage.out
Lines 1 to 14 in 61ff753
Which provides more information.
Editing the exists.sql file makes up for more work on PRs (example) while not providing any more test coverage.
exists.sql
Additionally, it's easier to locate all storage concerns in a single file, the same for the other schemas.
storage
Remove migrations/tests/database/exists.sql while ensuring the test coverage is preserved.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Problem
We currently have these tests:
postgres/migrations/tests/database/exists.sql
Lines 2 to 8 in 61ff753
As one example,
has_schema('storage');
is redundant withpostgres/nix/tests/expected/storage.out
Lines 1 to 14 in 61ff753
Which provides more information.
Editing the
exists.sql
file makes up for more work on PRs (example) while not providing any more test coverage.Additionally, it's easier to locate all
storage
concerns in a single file, the same for the other schemas.Solution
Remove
migrations/tests/database/exists.sql
while ensuring the test coverage is preserved.The text was updated successfully, but these errors were encountered: