Add support for file metadata, info and exists
#694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketApiImpl.kt
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketApiImpl.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketApiImpl.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketItem.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketItem.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketItem.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketItem.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileOptionBuilder.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileOptionBuilder.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileOptionBuilder.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileOptionBuilder.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileObject.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileObject.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileObject.kt
Fixed
Show fixed
Hide fixed
Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileObject.kt
Fixed
Show fixed
Hide fixed
grdsdev
requested changes
Aug 26, 2024
| return storage.api.postJson("object/list/$bucketId", buildJsonObject { | ||
| put("prefix", prefix) | ||
| putJsonObject(BucketListFilter().apply(filter).build()) | ||
| }).safeBody() | ||
| } | ||
|
|
||
| override suspend fun info(path: String): FileObjectV2 { | ||
| val response = storage.api.get("object/info/$bucketId/$path") |
There was a problem hiding this comment.
Hey, lets wait a bit for adding the info method as there is a bug in the JS lib, this should be object/info/public, but there is also a object/info/authenticated.
We're figuring out internally on how we're naming methods.
So lets just wait a bit before merging this.
There was a problem hiding this comment.
Yea, I commented on the JS PR regarding this. I couldn't make this work on the hosted Supabase instance, but the self-hosted Docker one works.
# Conflicts: # Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketApi.kt # Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/BucketApiImpl.kt # Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FileObject.kt # Storage/src/commonMain/kotlin/io/github/jan/supabase/storage/FlowExt.kt # Storage/src/commonTest/kotlin/BucketApiTest.kt
| @@ -13,6 +18,7 @@ | |||
| class UploadOptionBuilder( | |||
| @PublishedApi internal val serializer: SupabaseSerializer, | |||
| var upsert: Boolean = false, | |||
| var userMetadata: JsonObject? = null, | |||
Check warning
Code scanning / detekt
Public properties require documentation. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the new behavior?
Support for the new user metadata and the new
existsandinfomethods.For user metadata, there is a new
FileOptionBuilderwhen using any uploading method. To clean up the parameter list,upserthas been moved to this newFileOptionBuilder:Additionally, the
Storageplugin now also provides the ability to set a custom serializer.Additional context
See supabase/storage-js#207