Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu only works if the button is bottom the screen? #25

Open
elpatxificador opened this issue Aug 30, 2017 · 4 comments
Open

Menu only works if the button is bottom the screen? #25

elpatxificador opened this issue Aug 30, 2017 · 4 comments

Comments

@elpatxificador
Copy link

Hello, Congratulations for the project.
The menu only works if the button is bottom the screen.
Thanks you.
Regards.

@sunilsharma08
Copy link
Owner

Hi elpatxificador,

I have to add these feature in the library. Thanks for showing interest.

@FraDeliro
Copy link
Contributor

@sunilsharma08 I have added this feature for showing menu on top or bottom. But I have implemented it based on my last pull request branch because I have separated the part where you set the layout. If you accept my PR I will send you this new part too, if not, I will implement it again based on your current code ;)
Thanks

@sunilsharma08
Copy link
Owner

Hi FraDeliro,
I have accepted your PR and please raise PR to develop branch. I making all new changes in develop branch and once everything is stable I will merge it to master and make new release of library.

@FraDeliro
Copy link
Contributor

FraDeliro commented Oct 4, 2017

For Sure, thanks.
Let me know if everything is ok ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants