-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file input component #722
Comments
Hi folks, As this checklist seem to be fulfilled...
What would be the pattern you want to use in this Component ?
We do the number Two: onFileSelection / FileChange, we upload the file content to a server, and retrieve an Id (it could be an url, with S3); we use the response of this request as values for the component. It should be usable as a controlled & uncontrolled input, I imagine. Here are some screenshots. We will have to work on it soon, I'd rather do it in the right direction if you think it can be valuable for Circuit. |
Hey @connor-baer Can I contribute to this. Or anything that can get me going for this repo. I really wants to contribute to design system. |
Thanks for the offer, @harshilparmar, I appreciate your enthusiasm! Unfortunately, we currently don't accept outside contributions:
|
Visual
These are mockups and should not be used as the final design.
Context
This component can be used when a user is asked to upload any type of file. Examples include a profile photo, documents for verification, or paper receipts.
State
The component has multiple states which are not mutually exclusive:
Progressive enhancement
The component should be built on top of the native file input element (
<input type="file" />
). This ensures the greatest compatibility and best user experience on all devices.Further reading: Using files from web applications (MDN)
The text was updated successfully, but these errors were encountered: