Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Consistency #446

Open
bobbrodie opened this issue Apr 28, 2024 · 0 comments
Open

Test Consistency #446

bobbrodie opened this issue Apr 28, 2024 · 0 comments
Labels
Maintenance Chores, dependency updates, etc.

Comments

@bobbrodie
Copy link
Member

Is your feature request related to a problem? Please describe.
Getting back into this gem, I've noticed we have a ton of inconsistency across tests:

  • Clients are instantiated differently
  • Sometimes there is a context_path, sometimes there isn't
  • The site can differ (http://foo.com/, https://localhost:2990, etc.)
  • Doubles are used differently across the tests
  • There's a lot of duplication we can clean up

Describe the solution you'd like
We should review all the tests and mocks, and make them more consistent.
@bobbrodie bobbrodie added the Maintenance Chores, dependency updates, etc. label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Chores, dependency updates, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbrodie