Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger: BadKeyHandle APDU error code should be BadData #133

Closed
DaniPopes opened this issue Jan 31, 2024 · 1 comment
Closed

ledger: BadKeyHandle APDU error code should be BadData #133

DaniPopes opened this issue Jan 31, 2024 · 1 comment

Comments

@DaniPopes
Copy link
Contributor

DaniPopes commented Jan 31, 2024 •
edited
Loading

Officially 6a 80 -> "The parameters in the data field are incorrect.":

coins/ledger/src/common.rs

Lines 216 to 217 in 32463b1

/// BadKeyHandle
BadKeyHandle = 0x6A80,

Ledger uses this just about everywhere to indicate "bad data", just search for 0x6a80, 0x6A80 or APDU_RESPONSE_INVALID_DATA (e.g. https://github.com/LedgerHQ/app-ethereum/blob/develop/src_features/signTx/cmd_signTx.c#L25-L29)

A better name would probably be BadData
@DaniPopes
Copy link
Contributor Author

#134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DaniPopes