Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/adopt dunglas/symfony-docker? #270

Open
toaotc opened this issue Jan 27, 2025 · 2 comments
Open

Implement/adopt dunglas/symfony-docker? #270

toaotc opened this issue Jan 27, 2025 · 2 comments

Comments

@toaotc
Copy link

toaotc commented Jan 27, 2025

Problem:

The skeleton is not completely ready to run. At least the Docker container for PHP is missing.

Solution:

Extend Docker compose setup with PHP Container and maybe web server.

#Approach
Include Symfony Docker into the sulu/skeleton.

Please give thumbs up/down to let me know, if such a pull request would be welcome.

@alexander-schranz
Copy link
Member

alexander-schranz commented Jan 28, 2025

@toaotc we will not add to the skeleton a docker php container. We will keep the skeleton as near as possible to existing symfony skeleton.

You cann add Symfony Docker if you want it, personally I think it make specially on Macs a lot easier to run PHP locally, to be fast and debug things. But nothing speaks again if it is performant for you to add after installation Symfony Docker like you add it to your Symfony project itself.

Please have a look at sulu/sulu-docs#829, please test it so we have some feedback for somebody who is using it itself.

@opctim
Copy link

opctim commented Feb 4, 2025

@toaotc I did just that, see https://github.com/opctim/sulu-skeleton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants