Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElasticSearch 8 in composer.json #651

Closed
mortis0 opened this issue Nov 2, 2023 · 3 comments
Closed

Add ElasticSearch 8 in composer.json #651

mortis0 opened this issue Nov 2, 2023 · 3 comments

Comments

@mortis0
Copy link

mortis0 commented Nov 2, 2023

Q A
Bug? no
New Feature? yes

The bundle has a dependency on elasticsearch/elasticsearch but never use it directly, only through handcraftedinthealps/elasticsearch-bundle, so it would be nice to add elasticsearch/elasticsearch ^8 and handcraftedinthealps/elasticsearch-dsl ^8 to the composer.json

That would allow to replace only handcraftedinthealps/elasticsearch-bundle to make the article bundle work with ES 8

@alexander-schranz
Copy link
Member

There is not yet full support for Elasticsearch 8. It requires also update the massive search bundle to support Elasticsearch 8 which is currently failing on ES8 server version.

#608

@mortis0
Copy link
Author

mortis0 commented Feb 8, 2024

Thanks for your answer, my point was just that as ArticleBundle do not depends directly on elasticsearc/elasticsearch, why put a require on this package in it ? In my case, we manage to work with an ES8 with some adjustements in handcraftedinthealps/elasticsearch-bundle and massive-search-bundle, and then we had to fork article-bundle just to modify its composer.json to allow ES 8
Anyway, this is just a small inconvenience, thanks for your amazing work

@mortis0 mortis0 closed this as completed Feb 8, 2024
@alexander-schranz
Copy link
Member

Thank you. The queries written in the article bundle are for a specific elasticsearch version. Even we not directly use the Elasticsearch Client Library. We indirectly have over the query and configured options a dependency to a specific client/server version of Elasticsearch that is why we define it here also for transparency what versions of the server are currently supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants