Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source map errors #357

Closed
quozl opened this issue Jan 26, 2022 · 3 comments
Closed

Source map errors #357

quozl opened this issue Jan 26, 2022 · 3 comments

Comments

@quozl
Copy link
Contributor

quozl commented Jan 26, 2022

No impact, but Firefox browser tools says

Source map error: Error: request failed with status 404
Resource URL: http://www.sugarlabs.org/css/bootstrap.css
Source Map URL: bootstrap.css.map
@S-kus
Copy link
Contributor

S-kus commented Jan 26, 2022

When I am migrating it from bootstrap v3 to v4 in #347 I found out it's happening because of commented link in bootstrap.css in line 8975 i.e. last line.
We can solve it by adding the bootstrap.css.map file from official documents of Bootstrap v4 in the same CSS folder.
Can I raise the pr by adding the file? Do I need to update the Licence file also?

@quozl quozl closed this as completed in 8a8fbe3 Jan 26, 2022
@quozl
Copy link
Contributor Author

quozl commented Jan 26, 2022

When I am migrating it from bootstrap v3 to v4 in #347 I found out it's happening because of commented link in bootstrap.css in line 8975 i.e. last line. We can solve it by adding the bootstrap.css.map file from official documents of Bootstrap v4 in the same CSS folder.

Thanks. Fixed.

Can I raise the pr by adding the file?

I'm tired of being asked. It's about time you read our guide to Contributing in particular where it starts out saying

"Please note there is no need to ask permission to work on an issue. You should check for pull requests linked to an issue you are addressing; if there are none, then assume nobody has done anything. Begin to fix the problem, test, make your commits, push your commits, then make a pull request. Mention an issue number in the pull request, but not the commit message. These practices allow the competition of ideas (Sugar Labs is a meritocracy)."

😁

Do I need to update the Licence file also?

Nothing about the license file needs to change, does it?

@S-kus
Copy link
Contributor

S-kus commented Jan 26, 2022

Nothing about the license file needs to change, does it?

No, Sorry! I misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants