Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas is scrolling on drag and select #4063

Open
4 tasks done
therealharshit opened this issue Nov 17, 2024 · 4 comments · May be fixed by #4064
Open
4 tasks done

Canvas is scrolling on drag and select #4063

therealharshit opened this issue Nov 17, 2024 · 4 comments · May be fixed by #4064
Labels
Issue-Bug

Comments

@therealharshit
Copy link
Contributor

Description

When we try to select a block using drag and select, the canvas is scrolling which is making it difficult to select the block.

Expected Behavior

The canvas should not scroll when we drag to select.

Vedio

scroll-on-select.mp4

How to Reproduce

  1. Drag on canvas to select a block.
  2. You can see the canvas scrolling, making it difficult to select the block.

(Refer to the vedio for more info)

Console log Errors:

No console log errors

Environment:

  • Operating System: Windows
  • Browser (if applicable): Chrome
  • Version of Software/Project: [e.g., v1.0.0]

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.
@therealharshit
Copy link
Contributor Author

@walterbender this issue is on the master branch, I think some recent changes has caused this issue.

@walterbender
Copy link
Member

Yes. Not sure which of the changes related to dragging on the nav bar broke things, but I suspect it was one of those changes.

@therealharshit
Copy link
Contributor Author

Yes. Not sure which of the changes related to dragging on the nav bar broke things, but I suspect it was one of those changes.

No it's not related to dragging on nav, this issue was there before that fix.
@walterbender I am working on it.

therealharshit added a commit to therealharshit/musicblocks that referenced this issue Nov 17, 2024
@therealharshit
Fixes sugarlabs#4063 Canvas is scrolling on drag and select
3ca88d2
@therealharshit therealharshit linked a pull request Nov 17, 2024 that will close this issue
Open
@therealharshit
Copy link
Contributor Author

@walterbender it was this b5be318 commit which caused this issue, I have made the required changes to it to fix this issue.
Please review it in my PR #4064 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4063 Canvas is scrolling on drag and select therealharshit/musicblocks
2 participants
@walterbender @therealharshit