Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new notes disables the keyboard #4061

Open
4 tasks done
walterbender opened this issue Nov 16, 2024 · 2 comments
Open
4 tasks done

Adding new notes disables the keyboard #4061

walterbender opened this issue Nov 16, 2024 · 2 comments
Labels
Component-Widget relating to a widget Issue-Bug Issue-Regression Something that worked in the past is now broken

Comments

@walterbender
Copy link
Member

Description

The new note feature of the music keyboard widget adds notes, but then the keyboard cannot be played. This only happens with new letter notes. Adding hertz notes doesn't impact playing the keyboard.

Expected Behavior

The keyboard should play properly after adding new notes.

How to Reproduce

Open the music keyboard widget. Play some notes. Then click on the + button. Select the add new note button on the pie menu (right side). Close the menu. You can no longer play notes.

Console log Errors:

Uncaught TypeError: Cannot set properties of undefined (setting 'objId')
at MusicKeyboard._createKeyboard (musickeyboard.js:2868:38)
at musickeyboard.js:2098:26

Environment:

Chrome/Fedora/latest master

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@omsuneri
Copy link
Contributor

@walterbender i ll be working on this issue

@omsuneri
Copy link
Contributor

i found that after adding a new note the keyboard disabled itself but when you close the keyboard widget and again open the widget the keyboard get active and working fine
@walterbender i ll look into this why this is so raised

@walterbender walterbender added Component-Widget relating to a widget Issue-Regression Something that worked in the past is now broken labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Widget relating to a widget Issue-Bug Issue-Regression Something that worked in the past is now broken
Projects
None yet
Development

No branches or pull requests

2 participants