Scalar Step doesn't work for default temperaments (other than 12EDO)

[pikurasa]

Description

Scalar step steps up to the 5th scale degree and stops there for all the default temperaments other than 12EDO.

Expected Behavior

Scalar step should be able to step up scale degrees 1-8 (as well as other octaves) for any of our temperaments.

Screenshots

This video shows the issue: temperament-test-2024-09-23_10.51.50.zip

How to Reproduce

You can use this file to test: temperament-scalar-step.zip (this is the test file that was used to generate the video attached above)

Console log Errors:

N/A

[omsuneri]

@pikurasa yaa i can reproduce the issue so tis might be the issue when while designing the temperament what do you think over this i ll try to resolve this issue at my best

[pikurasa]

@pikurasa yaa i can reproduce the issue so tis might be the issue when while designing the temperament what do you think over this i ll try to resolve this issue at my best

This issue may be challenging, but feel free to work on it.

[omsuneri]

can you guide me to land the origination of this issue

[akshayw1]

Can I work on the issue?

[pikurasa]

Can I work on the issue?

You may.

I recommend you join https://matrix.to/#/#musicblocksdev:matrix.org to facilitate development and ask questions.

[omsuneri]

@pikurasa I found that some of the approximate value for the temperaments like equal 19EDO are slightly wrong so this might be causing due to that

[akshayw1]

@omsuneri , You are working on the same?

[omsuneri]

@akshayw1 yaa actually it was the bug found after the last commit so I'm working on it

[pikurasa]

You may work together, too. There's no reason that only one person needs to solve this. We respect and value solutions done collaboratively.

[omsuneri]

Yeah @pikurasa 😊

[omsuneri]

@pikurasa as far i had observed the scalar step +/- is working fine with the equal 12EDO and custom temperament but not with the other temperament so what i figured out is when i create an function of isCustomTemperament fun and allows the both cases to follow the same path the issue is resolved i can show you in the
temperament resolved.zip
but i think it may be the more optimised what do you think over it

[omsuneri]

@pikurasa i think this issue need to be closed as its solved again we have #4033