Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two copies of BeautifulSoup.py #29

Open
quozl opened this issue Apr 3, 2019 · 5 comments
Open

Two copies of BeautifulSoup.py #29

quozl opened this issue Apr 3, 2019 · 5 comments

Comments

@quozl
Copy link
Contributor

quozl commented Apr 3, 2019

We have two copies of BeautifulSoup.py in the source repository, of different versions.

@Aniket21mathur
Copy link
Contributor

What I can conclude by analysis of the source code is that we are using some files from the old version which in turn have its own BeautifulSoup file. For proper working of the activity both the files are of significance for us. This issue points to the problem of having two copies and can be fixed by figuring out a way to merge the two files so that we are left with one. Am I right?

@quozl
Copy link
Contributor Author

quozl commented May 17, 2019

Yes. Please propose ways to do this. The ways I can think of are;

  • remove one file and replace it with a symbolic link to the other,
  • change the imports so that a single file is used,
  • remove the file and require the installation of a dependency on the system, or;
  • switch to using import requests.

(Although the last two would break compatibility with OLPC OS on XO-1 through to XO-4, which use Fedora 18, this is minor given the activity once ported to Python 3 won't run on those systems anyway. Someone will be maintaining a branch for Fedora 18 regardless.)

@chimosky

This comment has been minimized.

@quozl

This comment has been minimized.

@chimosky

This comment has been minimized.

@chimosky chimosky mentioned this issue Jun 7, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants