Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up easel.js code #4

Open
walterbender opened this issue May 24, 2016 · 3 comments
Open

clean up easel.js code #4

walterbender opened this issue May 24, 2016 · 3 comments

Comments

@walterbender
Copy link
Member

walterbender commented May 24, 2016

I learned a lot about JS and Easel.js since writing this test app. Could use a major overhaul.

@sachi-d
Copy link
Contributor

sachi-d commented Jan 23, 2017

One of the major issues is not using certain features that are in the code
Eg. checking hits on dots - the code is halfway there (hit area) but not competed. How would you want to complete it? We could

  1. change the color of the number when hit in the correct order
  2. use soundjs to add a sound
  3. use a graphical method to indicate it

We could extend the method to indicate when all the dots are completed.

@walterbender
Copy link
Member Author

Would be nice perhaps to add a bit of sound when the dots are hit? Maybe a click sound when the order is correct and a buzz if some sort when out of order.

@sachi-d
Copy link
Contributor

sachi-d commented Jan 23, 2017

I added sound effects for hitting dots in correct order and finishing the order (Branch addSoundEffects). But soundjs does not work for locally run files (which I found only after working on it since I tested using bracket's live preview).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants