Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License not added #7

Open
Aniket21mathur opened this issue Dec 14, 2019 · 8 comments
Open

License not added #7

Aniket21mathur opened this issue Dec 14, 2019 · 8 comments

Comments

@Aniket21mathur
Copy link

Aniket21mathur commented Dec 14, 2019

Activity bundle /home/activities/calendario does not specify a license

@quozl
Copy link
Contributor

quozl commented Dec 15, 2019

Thanks. Reviewed source.

Is caused by spelling error in activity.info file.

Also, from review;

  • license should say GPLv3+ because the + means "or any later version",
  • license short texts don't comply with pep8,
  • MANIFEST is deprecated,
  • locale should not have been included, as it is generated from po.
  • many po files are empty,
  • many new po files are available at translate.sugarlabs.org,
  • the POT file needs a refresh,
  • README should be README.md and contain our standard components,
  • Wiki content can be moved from http://wiki.sugarlabs.org/go/Activities/calendario and added to README.md or a Help Activity entry.

@ayushnawal
Copy link
Contributor

@Aniket21mathur, please review the changes. Thanks!

This was referenced Dec 16, 2019
@ayushnawal
Copy link
Contributor

can close the issue now?

@quozl
Copy link
Contributor

quozl commented Jan 9, 2020

Remaining is the migration of Wiki content to README.md or Help Activity.

@ayushnawal
Copy link
Contributor

I don't have idea of the wiki content. Can I get a little help here in fixing this so that checklist made by you gets completed 😁

@quozl
Copy link
Contributor

quozl commented Jan 24, 2020

Remaining is the migration of Wiki content to README.md or Help Activity.

I don't have idea of the wiki content. Can I get a little help here in fixing this so that checklist made by you gets completed

I'm mystified. Can you be more specific about what you don't understand?

@ayushnawal
Copy link
Contributor

I don't have much idea about help activity, so I got confused that where we have to migrate the wiki content

@quozl
Copy link
Contributor

quozl commented Jan 25, 2020

Thanks for asking. I see we missed telling you some important things.

The Help activity is a Sugar activity containing documentation about Sugar and activities. The documentation is also hosted at https://help.sugarlabs.org/ for viewing outside Sugar. On a system running Sugar, the Help activity can be started by typing Help or clicking on the icon. The Help activity runs the Browse activity and points the browser at the documentation. Also, there's a shortcut in Sugar for an embedded context-sensitive help, using the Frame or a shortcut alt+shift+h.

Please read How to get started as a Sugar Labs developer, especially the first section about using Sugar as part of developing for Sugar Labs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants