Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/expand apps error states 243 #245

Open
wants to merge 5 commits into
base: dyno
Choose a base branch
from
Open

Feat/expand apps error states 243 #245

wants to merge 5 commits into from

Conversation

r-kirkbride
Copy link

@r-kirkbride r-kirkbride commented Nov 19, 2024 •
edited
Loading

Changes

  • Added verbose statuses for apps, bps and scs, including logging for those statuses.

Fixed Issue(s)

Closes #243
Closes #228

Checklist

  • Code has been tested on STM32 hardware.
  • Changes do not generate any new compiler warnings.
  • Code has been formatted using trunk fmt.
  • Commit messages follow the Conventional Commits specification.

@r-kirkbride r-kirkbride linked an issue Nov 19, 2024 that may be closed by this pull request
feat: Expand APPS error states #243
Open
1 task
@r-kirkbride r-kirkbride changed the base branch from main to dyno November 19, 2024 20:28
@r-kirkbride r-kirkbride self-assigned this Nov 19, 2024
@r-kirkbride
Copy link
Author

r-kirkbride commented Nov 19, 2024 •
edited
Loading

Tests

  • Check BPS reading is now logged. - should now show "BPS reading: {reading}; "
  • Test when apps & bps readings are outside of the threshold and the max diff - should log "{APPS/BPS} threshold error; "
    (maybe by temporarily adjusting the thresholds, so the reading falls outside the thresholds?)
  • Test when apps & bps readings are outside of the threshold but inside the max diff - should log "{APPS/BPS} threshold warning; "

Should never log "{APPS/BPS} unknown error; "

@r-kirkbride
Copy link
Author

r-kirkbride commented Nov 26, 2024 •
edited
Loading

Tests

  • Check BPS reading is now logged. - should now show "BPS reading: {reading}; "

This should now work correctly, was logging pointer value not the reading.

@r-kirkbride r-kirkbride linked an issue Dec 3, 2024 that may be closed by this pull request
feat: broadcast BPS messages #228
Open
2 tasks
tgodfrey0
tgodfrey0 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@tgodfrey0 tgodfrey0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodfrey0 tgodfrey0 tgodfrey0 approved these changes

Assignees

@r-kirkbride r-kirkbride

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Expand APPS error states feat: broadcast BPS messages
2 participants
@r-kirkbride @tgodfrey0