1. For header and footer, i will remove it from the index.html and lo… #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin.html and import them into the index.html and login.html which allow the footer and header can be reuse on multiple html page for this project. 2. For the registerCustomer.php, the if else statement which check for empty string, i will recommends to use 'empty($password)' instead of using password == " ". 3. I would like to remove the customer registration form from the index.html and create a register.html which easier for maintanance but i will still keep the layout of the orginal website.
|
Hey, welcome to this repository. We appreciate your efforts and contributions 🎉 |
Hooray 🚀🎉 Your changes are now live and can now be seen in the preview version on https://shoponline-web.000webhostapp.com/pull_request/ |
|
Will review and get back to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to do enhancement for this project. Below are my thoughts for these enhancements: