Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that a template is unique #404

Open
dilshat opened this issue May 22, 2018 · 4 comments
Open

Make sure that a template is unique #404

dilshat opened this issue May 22, 2018 · 4 comments
Assignees
@azretkenzhaliev
Labels
critical DONE
Milestone
June 4 - June 11

Comments

@dilshat
Copy link
Member

dilshat commented May 22, 2018

Only one template exists for a single combination of name, owner and version.
The combination of name+owner+version is a unique composite key for a template which can be used interchangeably with ID
@emli
Copy link
Contributor

emli commented May 22, 2018

Duplicated #220

@dilshat
Copy link
Member Author

dilshat commented May 22, 2018

@emli no this is now a bit different.
Issue #220 was valid before multiversion support was introduced
No we have to stick to the logic described above

@dilshat
Copy link
Member Author

dilshat commented May 22, 2018

About uploading a template with the same key (name+owner+version):
If a template with such key already exists then upload must fail and be allowed only if new version is higher

@azretkenzhaliev azretkenzhaliev added this to the May 21 - June 4 milestone May 22, 2018
@Almansherov Almansherov removed this from the May 21 - June 4 milestone May 22, 2018
azretkenzhaliev added a commit that referenced this issue Jun 9, 2018
@azretkenzhaliev
added fix for #404
f1f0bd8
@azretkenzhaliev azretkenzhaliev added this to the June 4 - June 11 milestone Jun 9, 2018
crioto added a commit that referenced this issue Jun 11, 2018
@crioto
Merge pull request #459 from subutai-io/404
6439491 
added fix for #404
@kurmanbekova6
Copy link

Fixed on Master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azretkenzhaliev azretkenzhaliev

Labels
critical DONE
Projects
None yet
Milestone
June 4 - June 11
Development

No branches or pull requests
5 participants
@dilshat @emli @azretkenzhaliev @kurmanbekova6 @Almansherov