Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error is shown when user tries to sign message with expired key #81

Open
samsonbek opened this issue Oct 23, 2018 · 2 comments
Open

Comments

@samsonbek
Copy link
Member

I have PGP key, which is expired. In popup dialog for signing message, I select this expired key, and signing doesn't occur. Just nothing happens. Reason is that key is expired. I think browser plugin must show some error or warning in such cases.

@samsonbek
Copy link
Member Author

By the way, with plugin of version 4.2.0 it is working. I mean that plugin doesn't check if key is expired or not.

@samsonbek
Copy link
Member Author

samsonbek commented Nov 22, 2018

I think E2E plugin must prohibit importing expired keys. Also if existing key is expired, in key list there should be some indicator(icon or label) of that. And expired keys must not be listed in drop-down select list, when you want to sign something with E2E plugin.

@crownIk crownIk self-assigned this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants