Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize sweet alert initialization on the websites #65

Open
zubaidullo opened this issue Apr 12, 2018 · 2 comments
Open

Optimize sweet alert initialization on the websites #65

zubaidullo opened this issue Apr 12, 2018 · 2 comments
Assignees
@TalasZh @zubaidullo
Labels
bug enhancement fixed in dev

Comments

@zubaidullo
Copy link
Contributor

Optimize sweet alert initialization on the websites, currently plugin adds default plugin Modal to any website, which is not good for users.
zubaidullo added a commit that referenced this issue Apr 18, 2018
@zubaidullo
#65: check if origin is Subutai component
24f5c48
zubaidullo added a commit that referenced this issue Apr 18, 2018
@zubaidullo
#65: check page title
792d8b7
@zubaidullo
Copy link
Contributor Author

How to test: E2E plugin was initializing swal modal popup on the bottom of ever website. You can check viewing page source. Now, that should appear only on Subutai Console and Subuai Bazaar

@AlinaPenkina
Copy link

Checked on Chrome and Mozilla. Waiting for new version for Edge and Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TalasZh TalasZh

@zubaidullo zubaidullo

Labels
bug enhancement fixed in dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TalasZh @zubaidullo @AlinaPenkina