From 94fd8be266168952e2c6e85ae8bf89c1b4afdcba Mon Sep 17 00:00:00 2001
From: Tanish Moral <134790673+TanishMoral11@users.noreply.github.com>
Date: Wed, 30 Oct 2024 19:06:17 +0530
Subject: [PATCH] Fix #2652 : Improve splash screen implementation with new
 drawable and updated styles (#5559)

Fixes #2652: This PR aims to enhance the splash screen implementation by
making the following changes:

- **splash_image.xml**: Created a new layer-list drawable that includes
a background color (`@color/oppiaPrimaryLight`) and centers the splash
image (`@drawable/splash_page`).
- **splash_page.xml**: Modified the path data for the splash image and
removed the old clip-path to ensure proper rendering.
- **styles.xml**: Updated the `SplashScreenTheme` to reference the new
`splash_image` drawable and set `adjustViewBounds` to true, allowing for
better handling of different screen sizes.

These changes are intended to improve the visual consistency and
responsiveness of the splash screen across various devices.

## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...").
- [x] Any changes to `scripts/assets` files have their rationale
included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

Before :

https://github.com/user-attachments/assets/161eb1ca-57b1-4b63-829a-de41f1b99702

After :

https://github.com/user-attachments/assets/fcd480ff-aabd-4fe3-9887-b9bf50b276ac

---------

Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
---
 app/src/main/res/drawable/splash_image.xml | 5 +++++
 app/src/main/res/drawable/splash_page.xml  | 6 ------
 app/src/main/res/values/styles.xml         | 3 ++-
 3 files changed, 7 insertions(+), 7 deletions(-)
 create mode 100644 app/src/main/res/drawable/splash_image.xml

diff --git a/app/src/main/res/drawable/splash_image.xml b/app/src/main/res/drawable/splash_image.xml
new file mode 100644
index 00000000000..d71dfdee03e
--- /dev/null
+++ b/app/src/main/res/drawable/splash_image.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
+  <item android:drawable="@color/component_color_splash_activity_background_color" />
+  <item android:drawable="@drawable/splash_page" android:gravity="center"/>
+</layer-list>
diff --git a/app/src/main/res/drawable/splash_page.xml b/app/src/main/res/drawable/splash_page.xml
index 96790799d5d..a95dba7e5eb 100644
--- a/app/src/main/res/drawable/splash_page.xml
+++ b/app/src/main/res/drawable/splash_page.xml
@@ -3,12 +3,6 @@
     android:height="640dp"
     android:viewportWidth="360"
     android:viewportHeight="640">
-  <group>
-    <clip-path android:pathData="M0,0h360v640h-360z M 0,0"/>
-    <path
-        android:pathData="M0,0h360v640h-360z"
-        android:fillColor="#019489"/>
-  </group>
   <path
       android:pathData="M80,258c0,-6.78 1.62,-12.35 5.16,-17.27A23.25,23.25 0,0 1,100.65 231a30.08,30.08 0,0 1,14.68 0.94,22.51 22.51,0 0,1 12.72,10.43 26.89,26.89 0,0 1,3.37 10,36.05 36.05,0 0,1 0.14,9.68c-1.08,8.47 -4.93,15.28 -12.15,20a23.15,23.15 0,0 1,-11.91 3.88,26.84 26.84,0 0,1 -13,-2.4 23.73,23.73 0,0 1,-9.82 -8.77,28.77 28.77,0 0,1 -4.38,-12.28C80.17,260.72 80.07,259 80,258ZM105,275.24h0a6.62,6.62 0,0 1,0.17 -0.71,22.8 22.8,0 0,1 2.23,-6.07 11.78,11.78 0,0 1,3.24 -3.81c0.23,-0.2 0.23,-0.31 0.13,-0.54a3.9,3.9 0,0 1,2 -5.16,1.24 1.24,0 0,1 0.23,-0.11 4,4 0,0 1,5.17 2.3,4.22 4.22,0 0,1 0.23,2 4,4 0,0 1,-5.9 2.87c-0.34,-0.2 -0.64,-0.47 -1,-0.74 -3.78,3.1 -5,7.46 -5.74,12a1.14,1.14 0,0 0,0.31 0,15.8 15.8,0 0,0 7.35,-1.69 17.6,17.6 0,0 0,5.81 -4.49,20.44 20.44,0 0,0 2.87,-4.55 20.89,20.89 0,0 0,1.68 -8,27.87 27.87,0 0,0 -0.37,-5.06 17.58,17.58 0,0 0,-4.32 -9.11,14.66 14.66,0 0,0 -5.36,-3.81 18.8,18.8 0,0 0,-6.95 -1.42c-0.81,0 -1.66,0 -2.47,0.07a16.25,16.25 0,0 0,-11.87 5.94A17.1,17.1 0,0 0,89.58 250a20.29,20.29 0,0 0,-1.48 8.6,21.78 21.78,0 0,0 2.33,9.48 16.34,16.34 0,0 0,10.62 8.68c0.65,0.16 1.29,0.27 2,0.4a3.52,3.52 0,0 0,0 -0.61,41.92 41.92,0 0,0 -1.35,-8A18.49,18.49 0,0 0,99 262.64a0.5,0.5 0,0 0,-0.67 -0.24,4 4,0 0,1 -5,-2.59 4.61,4.61 0,0 1,-0.17 -1.18,4 4,0 0,1 3.91,-4 3.9,3.9 0,0 1,2.57 0.91,3.83 3.83,0 0,1 1.35,4 4.07,4.07 0,0 1,-1.42 2.23c0.27,0.44 0.57,0.81 0.81,1.25a27.63,27.63 0,0 1,3.21 10.42c0.06,0.58 0.16,1.15 0.23,1.76L104,275.2v-4.52a71.54,71.54 0,0 1,0.47 -8.54,30.53 30.53,0 0,1 1.85,-7.89 0.31,0.31 0,0 0,-0.1 -0.34,4 4,0 1,1 5.54,-1.15 3.92,3.92 0,0 1,-4 1.72c-0.31,0 -0.37,0 -0.47,0.24 -0.24,0.64 -0.51,1.28 -0.71,1.92a32.28,32.28 0,0 0,-1.15 5.94c-0.14,1.55 -0.3,3.1 -0.37,4.66s-0.07,2.9 -0.1,4.35a34.72,34.72 0,0 1,0.13 3.64Z"
       android:fillColor="#fff"/>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 61eaea05390..32fcd43fce6 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -74,7 +74,8 @@
   </style>
 
   <style name="SplashScreenTheme" parent="OppiaThemeWithoutActionBar">
-    <item name="android:windowBackground">@drawable/splash_page</item>
+    <item name="android:windowBackground">@drawable/splash_image</item>
+    <item name="android:adjustViewBounds">true</item>
     <item name="android:windowAnimationStyle">@style/FadeTransitionAnimation.Activity</item>
   </style>
   <!-- PREVIOUS BUTTON STYLE -->