Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/openapi ranking endpoints #93

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Conversation

shin0729
Copy link
Contributor

@shin0729 shin0729 commented Apr 5, 2024

チケットへのリンク

やったこと

-openapiのドキュメントの変更
→1. /scores/{user-id}/current-rank:の追加.ユーザーが自分の順位を確認できる機能を追加するために順位を返す
2. /scores/ranking:のレスポンスにランキングの全件数をを追加.何ページまで結果を表示できるかを考慮するためにレスポンスにランキングの全件数を含めました

やらないこと

  • 実際にハンドラー等の実装歯行いません

できるようになること(ユーザ目線)

  • なし.開発者はビュワーで確認できます

できなくなること(ユーザ目線)

-特になし

動作確認

-現状は実装に変更がないため確認はできない?ビュワーで存在は確認した

その他

  • パスはアンダースコアじゃなくてハイフンでつなぐのが良いらしい

Copy link
Collaborator

@h-takeyeah h-takeyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shin0729 shin0729 merged commit 022da64 into develop Apr 5, 2024
4 checks passed
@KinjiKawaguchi KinjiKawaguchi linked an issue Apr 5, 2024 that may be closed by this pull request
3 tasks
@h-takeyeah h-takeyeah deleted the docs/openapi-ranking-endpoints branch April 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]API/v1の仕様確定及び実装
2 participants