スコアが登録されていない時に空の配列を返すように修正 #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-takeyeah
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
よさそう！本題とは違うけどtyping-app側に生成されてるコード https://github.com/su-its/typing/blob/eaa94e4ea4791b413e1e312db6e528c4ed159bd0/typing-app/src/libs/api/v0.d.ts
がundefinedを許す形になってしまっているのでopenapi.yamlのcomponents:のところにrequiredをつけてみるとベターかもです。とりあえずこのPRとしてはOKそうなのでApprove 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク
resolve #130
resolve #132
やったこと
やらないこと
できるようになること（ユーザ目線）
できなくなること（ユーザ目線）
動作確認
その他